www.makemkv.com

powdeau wrote: Tue Jan 28, 2025 10:47 pm

deadchip12 wrote: Tue Jan 28, 2025 4:06 pm

RESET_9999 wrote: Tue Jan 28, 2025 3:55 pm ok then another difference is the offset trim test steps file has a 100 and 600nits trims while the other test files have 100-600-1000.

So please also try this one: https://drive.google.com/file/d/1PLh6lz ... drive_link

No brightness change in everything.

btw I have the same behavior on LG G4 internal player as @deadchip12 in all the tests you were talking about.

Wait you also see no brightness change with the original positive lift P5 steps (offset L2) test file? I just tested it on my C9 and I could see the brightness change so it's surprising to know it's different on the G4.

The C9 has a 600nits target (under 1000nits). The G4 has a target surely over 1000nits like the A95.

I tested on my 2000nits Hisense TV and the trims work even if there's no 1000nits trim... I have no idea whats its target but since its capable of 900nits (at 100%) and 2000nits (25%) it must have a target higher than 1000nits.

deadchip12 wrote: Tue Jan 28, 2025 10:59 pm

powdeau wrote: Tue Jan 28, 2025 10:47 pm

deadchip12 wrote: Tue Jan 28, 2025 4:06 pm
No brightness change in everything.

btw I have the same behavior on LG G4 internal player as @deadchip12 in all the tests you were talking about.

Wait you also see no brightness change with the original positive lift P5 steps (offset L2) test file? I just tested it on my C9 and I could see the brightness change so it's surprising to know it's different on the G4.

That's right.

@RESET_9999 how bad is it for watching real content?
Also, do you have a similar test where there are blank 1000nits trims, so I know it's not a bug caused by omitting those trims?

yes, I have some files with blank and active trims and I already did some tests about it.
https://drive.google.com/drive/u/1/fold ... JnvY8naE0X

On the C2:
100nits alone = extrapolated and trim are active
if the 600nits trim is blank then the 100nits trim is ignored regardless of the values
if there's a 1000nits blank trim, then the effect of the 100nits trim is considerably reduced but it still has an effect.

On a 400nits monitor:
100nits trim has an effect when there's a blank 600nits (because the display target is lower than the trim target)

So I expect the G4 to ignore the trims if 1000nits is blank. Having a blank trim is useful when the colorist want to be more aggressive on the 100trims without affecting the tone mapping of the other targets.

It's probably intended and it makes sense. The trims purpose is to adjust the tone mapping of low target nits display (100-1000) when the colorist is not satisfied with the default mapping(L1 only).
In the case of a 1000-nit grade movie, your TV is capable of displaying the content without tone mapping so it makes sense to ignore the 100-600nits or 100nits-only interpolation.
The colorist shouldn't be lifting the brightness higher than the master through the 100 or 600 trims in the first place. A lot of movies have trims done like that though.

quietvoid wrote: Mon Jan 27, 2025 11:44 am

nekno wrote: Mon Jan 27, 2025 4:30 amSo, not clear on why it mattered for HDR10+ -> DV generation.

HDR10+ does have scene length, start indices. See https://github.com/quietvoid/dovi_tool/ ... 87b715344f

Yeah, saw your patch there, thanks. What problem is it solving if the output RPU doesn't include the frame indices, and therefore doesn't care whether the shots start at 0 or at 86400 as long as the numbers are sequential?

@RESET_9999

CPM also mentions ''meta level 6'' which defaults to N. Should we also enable this manually (like level 5)??
What do you recommend please?

Also since activating L5 on my LG OLED G1 I have problems viewing content below the picture. Everything seems to get stuck under the lowest black bar now. Part of the buttons when you pause the video are now stuck under the lowest black bar, same for subtitles. Any suggestions how to fix this? Same for the top bar, Dolby logos get partly stuck beneath it also. Only showing part of the Dolby logo that way.
How to fix this? Can you help me?

nekno wrote: Wed Jan 29, 2025 5:07 am Yeah, saw your patch there, thanks. What problem is it solving if the output RPU doesn't include the frame indices, and therefore doesn't care whether the shots start at 0 or at 86400 as long as the numbers are sequential?

It matters only for the generation code because the rest of the code uses the indices of the list and ignores the per-frame info.
So the frame indices must start from 0.

daffie wrote: Wed Jan 29, 2025 7:18 am @RESET_9999

CPM also mentions ''meta level 6'' which defaults to N. Should we also enable this manually (like level 5)??
What do you recommend please?

Also since activating L5 on my LG OLED G1 I have problems viewing content below the picture. Everything seems to get stuck under the lowest black bar now. Part of the buttons when you pause the video are now stuck under the lowest black bar, same for subtitles. Any suggestions how to fix this? Same for the top bar, Dolby logos get partly stuck beneath it also. Only showing part of the Dolby logo that way.
How to fix this? Can you help me?

L6 is useless, N or Y is fine

Next build should have an option to set L5 always to 0 so the black bars wont hide anything and Positive offset lift will still work.

EDIT: actually the private builds already got that option:

levels module params now take number not Y/N

dolby_vision_keep_source_meta_level_5

0 - discard if present
1 - keep with source values or inject with zero values if missing
2 - keep with zero values or inject with zero values if missing [Default]

dolby_vision_keep_source_meta_level_6

0 - discard if present
1 - keep with source values [Default]

RESET_9999 wrote: Wed Jan 29, 2025 12:14 pm

daffie wrote: Wed Jan 29, 2025 7:18 am @RESET_9999

CPM also mentions ''meta level 6'' which defaults to N. Should we also enable this manually (like level 5)??
What do you recommend please?

Also since activating L5 on my LG OLED G1 I have problems viewing content below the picture. Everything seems to get stuck under the lowest black bar now. Part of the buttons when you pause the video are now stuck under the lowest black bar, same for subtitles. Any suggestions how to fix this? Same for the top bar, Dolby logos get partly stuck beneath it also. Only showing part of the Dolby logo that way.
How to fix this? Can you help me?

L6 is useless, N or Y is fine

Next build should have an option to set L5 always to 0 so the black bars wont hide anything and Positive offset lift will still work.

EDIT: actually the private builds already got that option:

levels module params now take number not Y/N

dolby_vision_keep_source_meta_level_5

0 - discard if present
1 - keep with source values or inject with zero values if missing
2 - keep with zero values or inject with zero values if missing [Default]

dolby_vision_keep_source_meta_level_6

0 - discard if present
1 - keep with source values [Default]

Any drawbacks of setting L5 to 0?

No, not if the colorist respects Dolby's best practice not to lift over 0.025 (2100)

RESET_9999 wrote: Thu Jan 30, 2025 1:01 am No, not if the colorist respects Dolby's best practice not to lift over 0.025 (2100)

And even if the colorist lifts over 0.025 (2100), the only downside is that the black borders get lifted together with the image.
Correct?

daffie wrote: Thu Jan 30, 2025 8:20 am And even if the colorist lifts over 0.025 (2100), the only downside is that the black borders get lifted together with the image.
Correct?

yes

RESET_9999 wrote: Thu Jan 30, 2025 11:48 am

daffie wrote: Thu Jan 30, 2025 8:20 am And even if the colorist lifts over 0.025 (2100), the only downside is that the black borders get lifted together with the image.
Correct?

yes

that would look terrible on the oled

deadchip12 wrote: Thu Jan 30, 2025 2:47 pm

RESET_9999 wrote: Thu Jan 30, 2025 11:48 am

daffie wrote: Thu Jan 30, 2025 8:20 am And even if the colorist lifts over 0.025 (2100), the only downside is that the black borders get lifted together with the image.
Correct?

yes

that would look terrible on the oled

That doesn't happen often anyway. You are making a problem about something that really isn't one in everyday use.
The other option is that everything is hidden behind the black bars (unless you have a very new OLED TV).

guys, did you saw the l1 plot from dark fate Fra-Me-STo-R release, looks very weird, right?