Fix libmakemkv1 tight versioned dependency on libavcodec due to call to private function

The place to discuss linux version of MakeMKV
Post Reply
prahal
Posts: 14
Joined: Wed Mar 13, 2024 12:42 am

Fix libmakemkv1 tight versioned dependency on libavcodec due to call to private function

Post by prahal »

I made this patch to import code from private libavcodec mpegaudiodecheader
avpriv_mpegaudio_decode_header in libmakemkv1 instead of calling this libavcodec private function.

https://salsa.debian.org/BenTheTechGuy/ ... 4d6e3fa3c0

This removes the tight dependency on minor version, especially in Debian deb packaging (though any non-broken packaging ought to have this tight dependency if a private function is called from a library if this package tooling was correct).

I mentioned this patch in viewtopic.php?p=168212&sid=ff3621ec6df4 ... bd#p168212 but did not get any feedback.

In Ben apt repository, this private call tight dependency prevents to upgrade libavcodec at each of their minor version upgrades.

Not that I find not upstream source repository to send a PR to, so I am opening this thread.
mike admin
Posts: 4083
Joined: Wed Nov 26, 2008 2:26 am
Contact:

Re: Fix libmakemkv1 tight versioned dependency on libavcodec due to call to private function

Post by mike admin »

This (avpriv dependency removal) will be fixed in the next version.
prahal
Posts: 14
Joined: Wed Mar 13, 2024 12:42 am

Re: Fix libmakemkv1 tight versioned dependency on libavcodec due to call to private function

Post by prahal »

mike admin wrote:
Sat Apr 05, 2025 7:46 pm
This (avpriv dependency removal) will be fixed in the next version.
I see 1.18.1 from 8th of April 2025 still has the private call avpriv_mpegaudio_decode_header in ffm_mpa_decode_header,
so I guess you mean the next release after the release that you were going to ship (your message was from the 5th of April 20225).

Just to make it clear to readers of this thread that 1.18.1 still has this tight dependency constraint. (and avoid them having to check in the source code as I did, no need for duplicate work).
Thanks a log for your work, I am eager to see Ben shipping makemkv in Debian repositories.
Post Reply