clearer logging?

[mattpr]

I find that the logs don't make it obvious in all cases which title a given group of messages refers to. In particular there are no "success" messages on start or end of each title so if you have non-fatal (preventing save) errors/warnings on a given title in a series of successful titles you can't tell which title they belong to unless you watch the rip process and Information > Output file in the GUI at the time the log-line appears.

(Full example log below.)

Log starts with:

Code: Select all

Saving 12 titles into directory /path/to/output_dir/d02

all clear so far.

Then:

Code: Select all

AV synchronization issues were found in file '/path/to/output_dir/d02/discname_t01.mkv' (title #2)

...hmm, I guess we are on t01 now, so I guess that means t00 went fine (zero log output)?

Then a short while later...

Code: Select all

Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'

and a bunch more errors.
... is that still t01 or a different title? Because we don't get any affirmative log output on successful save or title start, we don't know.

And then after all the errors...

Code: Select all

Failed to save title 2 to file /path/to/output_dir/d02/discname_t02.mkv

So by process of elimination (in this case) we assume the errors are with t02.

I guess staring at the log enough, I can usually figure out which title is having the problem... but it always takes me some scrolling back and forth to try and figure out. There have been times I wasn't sure and had to re-rip watching the GUI to figure out which title was having the non-fatal issue.

Suggestion:

Adding a title start (or end) log output would help to clearly delineate which title a group of log lines belongs to. This could either be done with a "starting" indicator for each title (e.g. Starting to extract title X to file /path/to/output_dir/d02/discname_tXX.mkv) or an ending indicator for each title (e.g. Successfully saved title X to file /path/to/output_dir/d02/discname_tXX.mkv)

Sample Log

Code: Select all

Saving 12 titles into directory /path/to/output_dir/d02
AV synchronization issues were found in file '/path/to/output_dir/d02/discname_t01.mkv' (title #2)
AV sync issue in stream 4 at 0:00:00 : Forced subtitles track #4 turned out to be empty and was removed from output file
AV sync issue in stream 6 at 0:00:00 : Forced subtitles track #6 turned out to be empty and was removed from output file
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Posix error - Input/output error' occurred while reading '/dev/rdisk3' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Error 'Scsi error - MEDIUM ERROR:L-EC UNCORRECTABLE ERROR' occurred while reading '/BDMV/STREAM/00355.m2ts' at offset '841089024'
Failed to save title 2 to file /path/to/output_dir/d02/discname_t02.mkv

Aside...

Is there a reason that title numbering is not consistent in makemkv?
In the GUI it is indexed from 1 and in the filenaming it is indexed from 0. I understand 0 indexing, but I don't understand the reason for inconsistency in terms of presentation to user. If they want to re-rip the t03 file, they need to remember to look for title #4 in the GUI.

e.g. discname_t01.mkv' (title #2)

It looks like the title number has been replaced in the GUI (Title Information panel when highlighting a single title) with expected output filename (ie with the t03 in it)...so that helps. But the numbering is still inconsistent in the log at least.

...and there seems to be a small bug (MakeMKV v1.16.7 darwin x64) in the logging in the "Failed to save" case. Note the indexes here are both 2.

Actual:

Code: Select all

Failed to save title 2 to file /path/to/output_dir/d02/discname_t02.mkv

Should be:

Code: Select all

Failed to save title 3 to file /path/to/output_dir/d02/discname_t02.mkv